Updating Brave to the latest release

orangezipper

First, I ask for your patience. I am new to Github and KCP. I did follow official KaOS documentation regarding KCP packaging. I successfully packaged the latest version of Brave on my laptop, installed it and have tested it. It passes the tests when I run pckcp against the new Brave package. The only changes I made were in the PKGBUILD file. Specifically I changed the following two fields:

pkgver=1.79.126
chromiumver=137.0.7151.119

I am new to Github and did not want to add the updated PKGBUILD file to the master branch, because what if I did it wrong? I created a new branch named v1.79.126. Would someone mind taking a look at my changes and if they are good to please add it to the master branch? This is my first time contributing and I want to make sure I am doing everything right.

Thanks!

-OZ

demm

No need to make a branch, anyone with a KCP account can edit & correct. GitHub has a full history of whatever anyone changes, so it is easy to see what is done, and if needed, correct some things.
And if the worst should happen (completely broken), a revert is just a few clicks.
And for this particular package, changes are simple, so all seems correct (nothing to build for this browser, just download and re-package).

orangezipper

[unknown] I understand. Since it was my very first time ever using Github, I didn't want to mess anything up.

I will commit the change to the master branch. Once it's committed does that mean people using the KCP Brave package will get a notice to upgrade to the new version?

demm

If they use the KCP update command, then yes, it will let them know about a newer version (see kcp --help for all the options). Also, KCP is built-in to Octopi, so once the database is updated, Octopi will show a notification too.

orangezipper

@[deleted] Very cool. That's great, thank you.